-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TRAVIS CI to add coveralls #287
Conversation
55f398f
to
c215b04
Compare
I have access to coveralls via incubator. I will test this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be good.
You can add the badge to the README:
[![Coverage Status](https://coveralls.io/repos/github/kubernetes-incubator/kompose/badge.svg?branch=master)](https://coveralls.io/github/kubernetes-incubator/kompose?branch=master)
c215b04
to
0943327
Compare
@sebgoa done. now let's see if these tests pass :) |
Updates travis to enable coveralls support. Fixes kubernetes#281
0943327
to
8d0a654
Compare
Currently this isn't working for some odd-reason (timing out). I'll be looking at an alternative fix. |
ok, I am going to merge it and fix it |
Why merge it if its not working? |
because I was tired of seeing this PR pending and seeing our code coverage on the front page will be good motivation to improve unit tests. afaik, you don't need a token for public repos... but yeah it is failing. |
To be honestly I don't see reason why it couldn't be fixed in this PR. Now front page shows no coverage and failed tests. I've done some digging around, and it is timeouting because it runs all unit test again for every package as separate
it takes a long time to start go test and travis-ci jobs has 15min timeout. Root cause for this is that for some reason We could run tests and collect all coverageprofiles into one file and than call But it still requires to run |
this is how kubernetes is dealing with this https://github.com/kubernetes/kubernetes/blob/master/hack/make-rules/test.sh#L228 |
Updates travis to enable coveralls support.
Fixes #281