Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fix #286

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Minor doc fix #286

merged 1 commit into from
Nov 21, 2016

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Nov 16, 2016

No description provided.

@surajssd
Copy link
Member

@containscafeine please sign linux foundation cla, otherwise fix LGTM

@surajssd surajssd added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 16, 2016
@concaf
Copy link
Contributor Author

concaf commented Nov 16, 2016

@surajssd just did!

@@ -119,7 +119,7 @@ If it is not a valid version try, make sure you have updated the godep repo with
1. Populate dependencies for your Kompose.

```console
cd $GOPATH/src/github.com/kubernetes-incubator
cd $GOPATH/src/github.com/kubernetes-incubator/kompose/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the trailing / :)

@sebgoa sebgoa merged commit e8d12c3 into kubernetes:master Nov 21, 2016
@cdrage
Copy link
Member

cdrage commented Nov 21, 2016

@sebgoa seems this was merged before the trailing / was removed. opened up #305

@sebgoa
Copy link
Contributor

sebgoa commented Nov 21, 2016

what's wrong with the trailing / ?

@cdrage
Copy link
Member

cdrage commented Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants