Make OpenShift inherit from Kubernetes #240
Conversation
|
This is just a first stab and not ready yet. @kadel we really need to refactor k8sutils.go and pull out some of those functions into a separate file I think. Help me find out which functions should go in what file. |
dustymabe
force-pushed
the
dusty-refactor-opts
branch
from
dfebdb9 to
6b7f2fc
Compare
dustymabe
changed the title
| @@ -242,6 +228,21 @@ func Down(c *cli.Context) { | |||
|
|
|||
| } | |||
|
|
|||
| // Convenience method to return the appropriate Transformer based on | |||
| // what provider we are using. | |||
| func getTransformer(opt kobject.ConvertOptions) transformer.Transformer { | |||
There was a problem hiding this comment.
can be this moved to transformer package?
There is GetLoader fce that is inside loader package, it might be better to have it in the same way.
There was a problem hiding this comment.
yeah - looks like this can't be done because then there would be an import cycle because transformer.go would need to import transformer/kubernetes, which imports transformer.
import cycle not allowed
This is so you can set Opts on instance creation of kubernetes.Kubernetes and openshift.Openshift. This is useful so that we can pass option information arround without having to do it on the call stack every time.
dustymabe
force-pushed
the
dusty-refactor-opts
branch
from
6b7f2fc to
51dea82
Compare
|
this is probably a change that needs 2 reviewers. @janetkuo, can you review? |
Agreed, second pair of eyes would be great. |
|
LGTM. Thanks @dustymabe 👍 |
No description provided.