Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong global --bundle/--dab input #198 #221

Merged
merged 1 commit into from
Oct 20, 2016
Merged

wrong global --bundle/--dab input #198 #221

merged 1 commit into from
Oct 20, 2016

Conversation

cab105
Copy link
Contributor

@cab105 cab105 commented Oct 19, 2016

Modified email address.

sebgoa
sebgoa reviewed Oct 19, 2016
View reviewed changes
Copy link
Contributor

@sebgoa sebgoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but let's get @tuna to LGTM

@sebgoa
Copy link
Contributor

sebgoa commented Oct 20, 2016

@kadel can you review this simple change ?

@kadel
Copy link
Member

kadel commented Oct 20, 2016

Ah, I didn't noticed that this is PR was recreated.

kadel
kadel approved these changes Oct 20, 2016
View reviewed changes
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadel kadel added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2016
@sebgoa sebgoa merged commit 3e81215 into kubernetes:master Oct 20, 2016
@ngtuna ngtuna mentioned this pull request Oct 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgoa sebgoa sebgoa left review comments

@kadel kadel kadel approved these changes

Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cab105 @sebgoa @kadel