kompose up/down create and delete pvc

[surajssd]

pvc will be parsed when passing objects via kube client to create various objects. Also while deleting pvc will be deleted.

Fixes #218

[dustymabe]

was trying to test this for openshift but seems like this change is only for kube - should we update both at the same time?

[dustymabe]

also managed to get this error - but not sure where it came from:

[dustymabe@media examples (dusty-mlbparks)]$ ../kompose up
We are going to create Kubernetes deployments and services for your Dockerized application. 
If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead. 

INFO[0000] Successfully created service: redis          
INFO[0000] Successfully created service: web            
INFO[0000] Successfully created deployment: redis       
INFO[0000] Successfully created deployment: web         

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods' for details.
[dustymabe@media examples (dusty-mlbparks)]$ ../kompose down 
INFO[0000] Successfully deleted service: redis          
INFO[0003] Successfully deleted deployment: redis       
FATA[0003] Error while deleting application: no reaper has been implemented for { PersistentVolumeClaim}

[surajssd]

@dustymabe sorry for not labeling it, so creating a PVC was easy thing to do, but looking at how can I delete it, it's not straightforward like other objects, so stuck on it right now, so mostly following code from kubectl

[surajssd]

So I need some review here with respect to how Undeploy is implemented, I feel even for undeploy we should get converted objects iterate on those and then type switch on it and delete objects, cleanly. The problem here is that with komposeObject there is no way to identify how many PVCs were created? And since the names of PVC follow index starting from 0. There is no easy way to understand their names. So I propose here to change current implementation to implementation similar to Deploy its just that instead of create we call delete.

[dustymabe]

hey suraj - this is working for openshift now :) - one thing though. should we modify the following line to include pvc for both kube and openshift?

Your application has been deployed to OpenShift. You can run 'oc get dc,svc,is' for details.

[surajssd]

@dustymabe sure done for k8s as well! That's nice catch!

Never mind #220 (comment) check latest changes!

[dustymabe]

Never mind #220 (comment) check latest changes!

so you figured out how to go about doing the undeploy?

[surajssd]

@dustymabe yes with @kadel 's help got some pointers earlier today from old code that once @ngtuna did here https://github.com/kubernetes-incubator/kompose/blob/e08ab06f2c1dacf2bae477bb5faace2feb387c90/pkg/transformer/kubernetes/kubernetes.go#L298

[dustymabe]

up/down seems to be working for me now. I'm good with this - just need a maintainer to review.

[dustymabe]

ping @ngtuna @janetkuo @kadel

[ngtuna]

Code LGTM. Haven't tested yet but @dustymabe did it.

[kadel]

I would add one small comment explaining TIMEOUT const. Otherwise LGTM 👍
Great work @surajssd

[kadel]

Can you add comment explaining what where this timeout is used or what is it for?

[surajssd]

@kadel done! https://github.com/kubernetes-incubator/kompose/pull/220/files#diff-08d4e6a1922a157aca193e75416bbb9cR48

Also merging :) Thanks @dustymabe @kadel and @ngtuna for reviewing!