Fix: Make the out flag print to one file using seperator #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedGrati
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
AhmedGrati
changed the title
k8s-ci-robot
added
size/XXL
AhmedGrati
changed the title
cdrage
approved these changes
Nov 30, 2022
| return r | ||
| } | ||
| // return r | ||
| // } |
| return fmt.Errorf("error in marshalling the List: %v", err) | ||
| } | ||
| data = []byte(fmt.Sprintf("---\n%s", data)) | ||
| printVal, err := transformer.Print("", dirName, "", data, opt.ToStdout, opt.GenerateJSON, f, opt.Provider) |
There was a problem hiding this comment.
good, but you need to add comments "this part add --- which unifies the file", etc.
| data = []byte(fmt.Sprintf("---\n%s", data)) | ||
| printVal, err := transformer.Print("", dirName, "", data, opt.ToStdout, opt.GenerateJSON, f, opt.Provider) | ||
| if err != nil { | ||
| return errors.Wrap(err, "transformer.Print failed") |
There was a problem hiding this comment.
I know this is outside the scope of the PR, but perhaps change this error output while you're at it :) "transformer to print to one single file failed" or something like that.
hangyan
approved these changes
Dec 1, 2022
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, cdrage, hangyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request solves #1539.
Implementation
Basically, it has the exact implementation of the
helm templatecommand. It will output all the k8s resources in one YAML file using the---separator. If the user specifies a JSON output, it will return an error since we cannot have multiple JSON resources in one file.