Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the port ID definition in kubernetes.go file #1515

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

AhmedGrati
Copy link
Contributor

Problem

Fix this issue. The problem was mainly, in the ID of each port.
In the previous implementation, the ID was composed of the ASCII code of the port number and its protocol. However, such implementation led to some inconveniences for the large port numbers. In fact, If you try this command fmt.Println(string(55546) == string(55547)) it will print true, which is not the desired behavior and it's the main cause behind the issue.

Solution

To overcome this issue, I just replaced the string() function with strconv.Itoa(). I added large close numbers in the tests suite, to ensure that we get the desired behavior.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @AhmedGrati!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AhmedGrati
Once this PR has been reviewed and has the lgtm label, please assign surajssd for approval by writing /assign @surajssd in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kadel and surajssd August 16, 2022 10:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 16, 2022
@cdrage
Copy link
Member

cdrage commented Aug 16, 2022

LGTM!

@cdrage cdrage merged commit 6512dd3 into kubernetes:master Aug 16, 2022
kadel pushed a commit to kadel/kompose that referenced this pull request Aug 29, 2022
@cdrage cdrage mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants