fix: change the port ID definition in kubernetes.go file #1515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix this issue. The problem was mainly, in the ID of each port.
In the previous implementation, the ID was composed of the ASCII code of the port number and its protocol. However, such implementation led to some inconveniences for the large port numbers. In fact, If you try this command
fmt.Println(string(55546) == string(55547))
it will printtrue
, which is not the desired behavior and it's the main cause behind the issue.Solution
To overcome this issue, I just replaced the
string()
function withstrconv.Itoa()
. I added large close numbers in the tests suite, to ensure that we get the desired behavior.