-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tcp/http liveness/readiness probe #1449
Support tcp/http liveness/readiness probe #1449
Conversation
@ichxxx Hi, thanks for the PR, codes looks great. Since we have support merge multiple service to one workload, it's recommned to add extra test for this case. Check out the |
@hangyan Support and test for multiple service merge was added |
And I find the annotations have a bit problem on multiple containers, that annotations just show info about one of the services, not all the services. |
What do you mean? Would you like to give an example? |
For example: version: "3.3"
services:
mongo:
image: mongo
labels:
kompose.service.group: "my-group"
kompose.service.healthcheck.liveness.tcp_port: 8080
mysql:
image: mysql
labels:
kompose.service.group: "my-group"
kompose.service.healthcheck.liveness.tcp_port: 8081 output-k8s.json {
"kind": "Deployment",
"apiVersion": "apps/v1",
"metadata": {
"name": "my-group",
"annotations": {
"kompose.service.group": "my-group",
"kompose.service.healthcheck.liveness.tcp_port": "8081"
}
},
"spec": {
"template": {
"metadata": {
"annotations": {
"kompose.service.group": "my-group",
"kompose.service.healthcheck.liveness.tcp_port": "8080"
}
},
"spec": {
"containers": [
{
"name": "mongo",
"livenessProbe": {
"tcpSocket": {
"port": 8080
}
}
},
{
"name": "mysql",
"livenessProbe": {
"tcpSocket": {
"port": 8081
}
}
}
]
}
}
}
} There are two serivces, I specify liveness probe by labels. |
We can create some sperate PRs to fix this. Does not seems a big issues for me now. I guess there are some issues exist for the service group feature. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hangyan, ichxxx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @ichxxx |
close #1427
Add extra labels to support tcp liveness/readiness probe and http readiness probe