Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libcompose project.Context{} instead of docker.Context{} #142

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Use libcompose project.Context{} instead of docker.Context{} #142

merged 1 commit into from
Sep 7, 2016

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Sep 4, 2016

Fix #134

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 5, 2016

Rebased

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 6, 2016

Can someone check this tiny but helpful change? @kadel @Runseb

@kadel
Copy link
Member

kadel commented Sep 6, 2016

I didn't checked what are differences between project.Context and docker.Context.
But if it compiles and works why not ;-)
LGTM

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 6, 2016

@kadel Yeah, In #134 Weitenghuang explained the difference.

We don't need to use libcompose's docker pkg context, if kompose is not meant to build a docker client.

project.Context is just enough for kompose I believe.

@surajssd surajssd added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2016
@ngtuna ngtuna merged commit c3ff052 into kubernetes:master Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngtuna @kadel @surajssd