Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--pvc-request-size" new command line parameter #1406

Merged

Conversation

ithaiq
Copy link
Contributor

@ithaiq ithaiq commented Aug 6, 2021

As mentioned in #1374 , currently it's not possible to set pvc-request-size in the command line parameter. So I add it.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @ithaiq!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ithaiq
To complete the pull request process, please assign janetkuo after the PR has been reviewed.
You can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cdrage and sebgoa August 6, 2021 15:34
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2021
@ithaiq
Copy link
Contributor Author

ithaiq commented Aug 6, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 6, 2021
cmd/convert.go Show resolved Hide resolved
@hangyan
Copy link
Contributor

hangyan commented Aug 7, 2021

@ithaiq Thanks for you contribution. Besides the code change, you may also need to go through the user docs to update related section and add unit test or command test

@ithaiq ithaiq closed this Aug 7, 2021
@ithaiq ithaiq reopened this Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2021
@ithaiq
Copy link
Contributor Author

ithaiq commented Aug 7, 2021

@ithaiq Thanks for you contribution. Besides the code change, you may also need to go through the user docs to update related section and add unit test or command test

I have added the unit tests and PASS

@hangyan
Copy link
Contributor

hangyan commented Aug 7, 2021

@ithaiq Please also update the user docs about volume size settings.

docs/conversion.md Outdated Show resolved Hide resolved
@ithaiq
Copy link
Contributor Author

ithaiq commented Aug 7, 2021

@ithaiq Please also update the user docs about volume size settings.

ok, I have already finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants