Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support assign nodeport port in labels #1210

Merged
merged 5 commits into from
Dec 26, 2019
Merged

Support assign nodeport port in labels #1210

merged 5 commits into from
Dec 26, 2019

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Dec 26, 2019

fix #1191

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from cdrage and kadel December 26, 2019 15:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hangyan
You can assign the PR to them by writing /assign @hangyan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hangyan hangyan merged commit 1f0a097 into kubernetes:master Dec 26, 2019
@hangyan hangyan deleted the nodeport-port branch December 26, 2019 15:46
@hangyan hangyan mentioned this pull request Dec 28, 2019
Closed
@datdenkikniet datdenkikniet mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@kadel kadel Awaiting requested review from kadel

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How kompose.service.type: nodeport customizes the port of nodePort to 30000
2 participants
@hangyan @k8s-ci-robot