Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to turn off push image when kompose up #1147

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add flag to turn off push image when kompose up #1147

merged 1 commit into from
Oct 31, 2019

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Jun 25, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from cdrage and concaf June 25, 2019 05:38
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2019
@hangyan
Copy link
Contributor Author

hangyan commented Jun 25, 2019

fix #1105

@jdbohrman
Copy link

Lmao just when I run into an issue that this would have resolved.

@hangyan
Copy link
Contributor Author

hangyan commented Jun 29, 2019

@jdbohrman you can build the binary from the source code in my repo if you are in a hurry

@orkenstein
Copy link

@hangyan thanks for the tip, i've been able to succesfully build & run kompose from this PR.
However, on kompose up I get this error:

FATA Error while deploying application: Get http://localhost:8080/api: dial tcp [::1]:8080: connect: connection refused

Any chance to avoid this?

@hangyan
Copy link
Contributor Author

hangyan commented Jun 29, 2019

@orkenstein unfortunately this issue is not a easy one , the upstream library we use seems does not allow us to change the target port, or it’s possible, but need a lot of time to figured out. Normally Kubernetes will listen on 8080 as an unsecure port, but may be the latest versions has disable it by default.You can check the command args of the apiserver binary, i think it has a flag to enable this. I’m trully sorry for the inconvenience

@orkenstein
Copy link

orkenstein commented Jun 29, 2019 •
edited
Loading

@hangyan, ah, no worries. I'd better wait for the release of this feature. Hope it happens soon...

@orkenstein
Copy link

@cdrage, @containscafeine, could you please review this & merge this?

@orkenstein
Copy link

@hangyan @cdrage @containscafeine, hope you get some time to finish this PR.
Thanks

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2019
@cdrage
Copy link
Member

cdrage commented Oct 31, 2019

Eh! This actually looks pretty good.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit ab111b5 into kubernetes:master Oct 31, 2019
@hangyan hangyan deleted the push-image-flag branch December 27, 2019 14:43
fetzerch added a commit to fetzerch/kompose that referenced this pull request Mar 3, 2020
@fetzerch
Add support for push-image with --build local
45c32c2 
The PR kubernetes#1147 introduced a
push-image parameter for the 'up' command that allows to disable
pushing the image to the registry. The PR changed the behavior of the
'convert' command that now no longer pushes the image.

This commit introduces the same parameter for the 'convert' command
and reintroduces the original behavior of pushing the image.
@fetzerch fetzerch mentioned this pull request Mar 3, 2020
Merged
hangyan pushed a commit that referenced this pull request Mar 8, 2020
@fetzerch
Add support for push-image with --build local (#1257)
2bdb326 
The PR #1147 introduced a
push-image parameter for the 'up' command that allows to disable
pushing the image to the registry. The PR changed the behavior of the
'convert' command that now no longer pushes the image.

This commit introduces the same parameter for the 'convert' command
and reintroduces the original behavior of pushing the image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@concaf concaf Awaiting requested review from concaf

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hangyan @jdbohrman @orkenstein @fejta-bot @cdrage @k8s-ci-robot