Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support read data from stdin #1061

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Support read data from stdin #1061

merged 1 commit into from
Oct 2, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Aug 9, 2018 •
edited
Loading

fix #1056
related to #871

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2018
@hangyan hangyan requested review from cdrage and surajnarwade and removed request for cdrage August 9, 2018 15:04
@cdrage
Copy link
Member

cdrage commented Oct 1, 2018

LGTM!

@hangyan hangyan merged commit b8aada8 into kubernetes:master Oct 2, 2018
@hangyan hangyan deleted the fix/stdin branch October 2, 2018 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@surajnarwade surajnarwade Awaiting requested review from surajnarwade

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read input from stdin does not work
3 participants
@hangyan @cdrage @k8s-ci-robot