Validate input args

[janetkuo]

I found myself often do this kompose convert abc.yml (should be kompose convert -f abc.yml) and kompose will convert docker-compose.yml for me without any warning (unexpectedly and surprisingly, if I don't pay attention).

kompose should print some error messages in this case to prevent misuse/confusion.

[surajssd]

@janetkuo this has been fixed in #211

$ kompose convert abc.yml
FATA[0000] Unknown Argument(s): abc.yml 

[sebgoa]

closing

[bittner]

$ kompose convert abc.yml
FATA[0000] Unknown Argument(s): abc.yml

This may be called "fixed" as for "will convert docker-compose.yml for me without any warning", but it's really a very confusing error message.

Show Case

I found myself in the situation that the usage is actually not matching the real behavior:

$ kompose path/to/docker-compose.yml 
Error: unknown command "path/to/docker-compose.yml" for "kompose"
Run 'kompose --help' for usage.
unknown command "path/to/docker-compose.yml" for "kompose"
$ kompose --help
Kompose is a tool to help users who are familiar with docker-compose move to Kubernetes.

Usage:
  kompose [command]

Available Commands:
  completion  Output shell completion code
  convert     Convert a Docker Compose file
  down        Delete instantiated services/deployments from kubernetes
  help        Help about any command
  up          Deploy your Dockerized application to a container orchestrator.
  version     Print the version of Kompose

Flags:
      --error-on-warning    Treat any warning as an error
  -f, --file stringArray    Specify an alternative compose file
  -h, --help                help for kompose
      --provider string     Specify a provider. Kubernetes or OpenShift. (default "kubernetes")
      --suppress-warnings   Suppress all warnings
  -v, --verbose             verbose output

Use "kompose [command] --help" for more information about a command.
$ kompose convert --help
Convert a Docker Compose file

Usage:
  kompose convert [file] [flags]

Kubernetes Flags:
      --daemon-set               Generate a Kubernetes daemonset object (deprecated, use --controller instead)
  -d, --deployment               Generate a Kubernetes deployment object (deprecated, use --controller instead)
  -c, --chart                    Create a Helm chart for converted objects
      --replication-controller   Generate a Kubernetes replication controller object (deprecated, use --controller instead)

OpenShift Flags:
      --build-branch             Specify repository branch to use for buildconfig (default is current branch name)
      --build-repo               Specify source repository for buildconfig (default is current branch's remote url)
      --deployment-config        Generate an OpenShift deployment config object
      --insecure-repository      Specify to use insecure docker repository while generating Openshift image stream object

Flags:
      --build string        Set the type of build ("local"|"build-config"(OpenShift only)|"none") (default "none")
      --controller string   Set the output controller ("deployment"|"daemonSet"|"replicationController")
  -h, --help                help for convert
  -j, --json                Generate resource files into JSON format
  -o, --out string          Specify a file name to save objects to
      --replicas int        Specify the number of replicas in the generated resource spec (default 1)
      --stdout              Print converted objects to stdout
      --volumes string      Volumes to be generated ("persistentVolumeClaim"|"emptyDir"|"hostPath") (default "persistentVolumeClaim")

Global Flags:
      --error-on-warning    Treat any warning as an error
  -f, --file stringArray    Specify an alternative compose file
      --provider string     Specify a provider. Kubernetes or OpenShift. (default "kubernetes")
      --suppress-warnings   Suppress all warnings
  -v, --verbose             verbose output

Alright, the file name after the "convert" command should be fine, shouldn't it? Let's try:

$ kompose convert path/to/docker-compose.yml
FATA Unknown Argument(s): path/to/docker-compose.yml
$ cd path/to/
$ kompose convert docker-compose.yml
FATA Unknown Argument(s): path/to/docker-compose.yml
$ kompose convert
WARN Unsupported depends_on key - ignoring
INFO Kubernetes file "web-service.yaml" created
INFO Kubernetes file "db-deployment.yaml" created
INFO Kubernetes file "web-deployment.yaml" created

It's simply not clear from the usage why specifying a file name after the "convert" command results in an "unknown argument".

Version Info

$ kompose --version
Error: unknown flag: --version
Usage:
  kompose [command]

Available Commands:
  completion  Output shell completion code
  convert     Convert a Docker Compose file
  down        Delete instantiated services/deployments from kubernetes
  help        Help about any command
  up          Deploy your Dockerized application to a container orchestrator.
  version     Print the version of Kompose

Flags:
      --error-on-warning    Treat any warning as an error
  -f, --file stringArray    Specify an alternative compose file
  -h, --help                help for kompose
      --provider string     Specify a provider. Kubernetes or OpenShift. (default "kubernetes")
      --suppress-warnings   Suppress all warnings
  -v, --verbose             verbose output

Use "kompose [command] --help" for more information about a command.

unknown flag: --version
$ kompose version
1.13.0 (84fa826)

🤦‍♀️ 🙈

[markstos]

This embarrassing flaw persists today.

Here's a project whose primary purpose is to convert docker-compose.yml files. Yet if you give it a docker-compose.yml file, it has no idea what you are talking about.

  FATA Unknown Argument(s): ./docker-compose.yml

FATA you too, kompose.

kompose convert --help could mention that it's going to look for `docker-compose.y(a?)ml by default.