v3 env substitution is not working

[bgruening]

Hi,

I have a few problems with the latest kompose version and the substitutions of env vars.

bag@bag ~/temp/foo % go get -u github.com/kubernetes-incubator/kompose                                                  
bag@bag ~/temp/foo % kompose version
0.7.0 (08658d3)

This small test file:

version: "3"
services:
  web:
    image: quay.io/bgruening/galaxy-web:${IMAGE_VER:-latest}
    environment:
        - GALAXY_RUNNERS_ENABLE_K8=${GALAXY_RUNNERS_ENABLE_K8}

result in this k8s file:

bag@bag ~/temp/foo % IMAGE_VER=foo GALAXY_RUNNERS_ENABLE_K8="asdf" kompose convert -f k8.yaml && cat web-deployment.yaml
INFO Kubernetes file "web-service.yaml" created   
INFO Kubernetes file "web-deployment.yaml" created 
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    io.kompose.service: web
  name: web
spec:
  replicas: 1
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        io.kompose.service: web
    spec:
      containers:
      - env:
        - name: GALAXY_RUNNERS_ENABLE_K8
        image: quay.io/bgruening/galaxy-web:latest
        name: web
        resources: {}
      restartPolicy: Always
status: {}

I tried to create an .env file

GALAXY_RUNNERS_ENABLE_K8=True
IMAGE_VER=8.9

and also exported it with no success.

- GALAXY_RUNNERS_ENABLE_K8=${GALAXY_RUNNERS_ENABLE_K8:-default} in the docker-compose.yml file will substitute it with default but not with the values available during runtime.
- GALAXY_RUNNERS_ENABLE_K8=$GALAXY_RUNNERS_ENABLE_K8 does not work at all.

Thanks a lot for any help!

[bgruening]

ping @cdrage as you have rocked the v3 world lately :)

[cdrage]

Hey @bgruening I'm going to have a look into this and see what's up! Other than the env variables, I'm assuming everything has converted correctly for docker-galaxy-stable?

[bgruening]

@cdrage galaxy-docker-stable is a very complicated beast and we have some more problems.

For example this one: bgruening/docker-galaxy@2c56ffa

An other thing is that I want to get this under CI testing. So I use ./hack/local-up-cluster.sh to start a k8s test env and in this it seems I need to have PV.yaml files which are not generated.

Coming back to the env problem this is the hack I'm currently using, maybe this helps in some way. It works reliable as bash is probably the best way to replace bash envs :)

#!/bin/bash
cat > $2 << EOF
`cat $1`
EOF

Thanks @cdrage for working on this!

[kadel]

hope I haven't stepped on your toe @cdrage 😇 I just wanted to look what is happening there, and saw a solution - #658 😉