Support for: group_add

[cdrage]

No error / warning when using this key.

[procrypt]

@cdrage group_add is supported by libcompose but I'm having some trouble using it, opened up an issue on libcompose.
docker/libcompose#446

[gitlawr]

upstream issue was fixed so I think we can take it a step further

[surajnarwade]

@cdrage @procrypt i think, group_add mapping doesn't make any sense in kompose, so it will be better to add it in unsupported keys, sending PR for the same :)

[cdrage]

@surajnarwade @surajssd @gitlawr

After some investigation, you are actually able to map this to securityContext: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/

[surajnarwade]

@cdrage , for docker-compose file like,

version: '2'
services:
  myservice:
    image: alpine
    group_add:
      - "1004"

it will be,

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    io.kompose.service: myservice
  name: myservice
spec:
  replicas: 1
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        io.kompose.service: myservice
    spec:
      containers:
      - image: alpine
        name: myservice
        resources: {}
      restartPolicy: Always
      securityContext:
        supplementalGroups:
        - 1004
status: {}

For, docker-compose we can mention group in string format but for kubernetes we need only group id

[surajnarwade]

@cdrage is that okay ?

[cdrage]

@surajnarwade Yup. That works perfectly.

[surajnarwade]

@cdrage , awesome, sending PR for the same

[cdrage]

This has been merged in! #739