Should we not generate PVC's by default?

[cdrage]

The current default is to generate a PVC with only 100Mb of available memory.

Ex:

WARN[0000] Unsupported depends_on key - ignoring
WARN[0000] Unsupported network_mode key - ignoring
WARN[0000] Volume mount on the host "./media" isn't supported - ignoring path on the host
WARN[0000] Volume mount on the host "./media" isn't supported - ignoring path on the host

Yet it still build PVC's.

Should we (by default) NOT generate volume mounts?

[kadel]

I'm not sure if I understand :-(
What are you proposing to do with volumes instead?

We already had this discussion in some other issue. I still think that PVC is right approach here.
And if for some reason you want to avoid that you can use --emptyvols option.

But I agree that 100Mb default is bad. We need to make this configurable for user.

[cdrage]

@kadel I find it odd that we have a default to 100Mb and the volumes are inherently not working correctly since it's ignored on the host.

[kadel]

The host part will always be a problem as we don't have easy way how to copy data from the machine to the cluster :-(

[surajssd]

@kadel I find it odd that we have a default to 100Mb and the volumes are inherently not working correctly since it's ignored on the host.

@cdrage can you elaborate what do you mean here?

[cdrage]

@surajssd We default to 100Mb in PVC's and if PV's aren't setup on the cluster Kompose won't warn the user / fail since PVC's will be stuck in a pending state the entire duration.

[surajssd]

@cdrage yes PVCs will fail when PV is not provisioned, but then kompose right now generates configs that are cluster agnostic with little extra setup needed.

We can expect PV to be setup already.

[kadel]

@surajssd, @cdrage is right. PVC will stay in Pending state if there is no matching PV. I'm not aware of any timeout setting for this so it will be probably stuck in Pending forever.

Reason for this is to allow PVC to be created before PV, PVC is waiting for someone to create PV.

[surajnarwade]

@kadel , @surajssd , @cdrage , as of now, should we add warning in kompose such as,
for example,

WARN[0000] volume "data-volume" of size "100 Mi" created

[cdrage]

@surajnarwade IMO, INFO instead of WARN may be better.

[kadel]

yeh, this shouldn't be WARN.
And message should probably mention something about PVC requiring PV. But I don't know how to explain it in one or two sentences 😞

[surajnarwade]

okay @kadel @cdrage I would like to work on it then

[surajssd]

@surajnarwade assigned!