Skip to content

Add go vet #215

Closed
Closed
@kadel

Description

@kadel

Tests that are run in travis-ci for every PR should include go vet to check for suspicious constructs and formatting errors.

we can create make test target that will run all tests (vet,unit,cmd)

current state:

$ for f in `find . -path ./vendor -prune -o -name '*.go' -print `; do go vet $f; done
cli/app/app_test.go:109: missing argument for Errorf("%s"): format reads arg 3, have only 2 args
cli/app/app_test.go:112: missing argument for Errorf("%s"): format reads arg 3, have only 2 args
cli/app/app_test.go:115: missing argument for Errorf("%s"): format reads arg 3, have only 2 args
cli/app/app_test.go:118: missing argument for Errorf("%s"): format reads arg 3, have only 2 args
pkg/loader/bundle/bundle.go:109: no formatting directive in Fatalf call
pkg/loader/bundle/bundle.go:114: no formatting directive in Fatalf call

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions