-
Notifications
You must be signed in to change notification settings - Fork 896
deploy datadog to kops eks cluster and upgrade argocd #8180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran Plan for dir: Plan Error Show Output
|
Ran Plan for dir: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# google_iam_workload_identity_pool_provider.eks_kops will be created
+ resource "google_iam_workload_identity_pool_provider" "eks_kops" {
+ attribute_mapping = {
+ "google.subject" = "assertion.sub"
}
+ display_name = "kops"
+ id = (known after apply)
+ name = (known after apply)
+ project = "k8s-infra-prow-build"
+ state = (known after apply)
+ workload_identity_pool_id = "prow-eks"
+ workload_identity_pool_provider_id = "kops"
+ oidc {
+ allowed_audiences = [
+ "sts.googleapis.com",
]
+ issuer_uri = "https://oidc.eks.us-east-2.amazonaws.com/id/7283E85C59E9C4129CFD07BAC9378D44"
}
}
# google_vmwareengine_network_peering.gvce_peering will be updated in-place
~ resource "google_vmwareengine_network_peering" "gvce_peering" {
~ export_custom_routes_with_public_ip = false -> true
id = "projects/k8s-infra-prow-build/locations/global/networkPeerings/peer-with-gcve-project"
~ import_custom_routes_with_public_ip = false -> true
name = "peer-with-gcve-project"
# (13 unchanged attributes hidden)
}
# module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/secretmanager.secretAccessor"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
id = "k8s-infra-prow-build/roles/secretmanager.secretAccessor"
~ members = [
- "principal://iam.googleapis.com/projects/180382678033/locations/global/workloadIdentityPools/k8s-infra-prow-build-trusted.svc.id.goog/subject/ns/external-secrets/sa/external-secrets",
# (2 unchanged elements hidden)
]
# (3 unchanged attributes hidden)
}
# module.prow_build_nodepool_c4_highmem_8_localssd.google_container_node_pool.node_pool will be updated in-place
~ resource "google_container_node_pool" "node_pool" {
id = "projects/k8s-infra-prow-build/locations/us-central1/clusters/prow-build/nodePools/pool6-20250327232037500200000001"
name = "pool6-20250327232037500200000001"
# (10 unchanged attributes hidden)
~ autoscaling {
~ max_node_count = 25 -> 80
# (4 unchanged attributes hidden)
}
# (3 unchanged blocks hidden)
}
Plan: 1 to add, 3 to change, 0 to destroy.
Plan: 1 to add, 3 to change, 0 to destroy.
|
I don't advise to run anything in the kOps cluster. This cluster is supposed to be gone by EoY. All prowjobs should run the |
I'm trying the dd deployment here before running it on the main cluster. We'll clean it up before decommissioning the cluster at the end of the year. |
Ran Plan for dir: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# google_iam_workload_identity_pool_provider.eks_kops will be created
+ resource "google_iam_workload_identity_pool_provider" "eks_kops" {
+ attribute_mapping = {
+ "google.subject" = "assertion.sub"
}
+ display_name = "kops"
+ id = (known after apply)
+ name = (known after apply)
+ project = "k8s-infra-prow-build"
+ state = (known after apply)
+ workload_identity_pool_id = "prow-eks"
+ workload_identity_pool_provider_id = "kops"
+ oidc {
+ allowed_audiences = [
+ "sts.googleapis.com",
]
+ issuer_uri = "https://oidc.eks.us-east-2.amazonaws.com/id/7283E85C59E9C4129CFD07BAC9378D44"
}
}
# google_vmwareengine_network_peering.gvce_peering will be updated in-place
~ resource "google_vmwareengine_network_peering" "gvce_peering" {
~ export_custom_routes_with_public_ip = false -> true
id = "projects/k8s-infra-prow-build/locations/global/networkPeerings/peer-with-gcve-project"
~ import_custom_routes_with_public_ip = false -> true
name = "peer-with-gcve-project"
# (13 unchanged attributes hidden)
}
# module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/secretmanager.secretAccessor"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
id = "k8s-infra-prow-build/roles/secretmanager.secretAccessor"
~ members = [
- "principal://iam.googleapis.com/projects/180382678033/locations/global/workloadIdentityPools/k8s-infra-prow-build-trusted.svc.id.goog/subject/ns/external-secrets/sa/external-secrets",
# (2 unchanged elements hidden)
]
# (3 unchanged attributes hidden)
}
# module.prow_build_nodepool_c4_highmem_8_localssd.google_container_node_pool.node_pool will be updated in-place
~ resource "google_container_node_pool" "node_pool" {
id = "projects/k8s-infra-prow-build/locations/us-central1/clusters/prow-build/nodePools/pool6-20250327232037500200000001"
name = "pool6-20250327232037500200000001"
# (10 unchanged attributes hidden)
~ autoscaling {
~ max_node_count = 25 -> 80
# (4 unchanged attributes hidden)
}
# (3 unchanged blocks hidden)
}
Plan: 1 to add, 3 to change, 0 to destroy.
Plan: 1 to add, 3 to change, 0 to destroy.
|
/lgtm |
Locks and plans deleted for the projects and workspaces modified in this pull request:
|
I upgraded argocd and configured it to assume an AWS role that grants access to the EKS clusters and I connected the kops EKS cluster to ArgoCD
Part of #5170
Manual changes I need to reconcile: