Skip to content

add c4 nodepool to trusted cluster #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jun 3, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ labels Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2025
@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-infra-prow-build-trusted workspace: default

Show Output
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # module.prow_build_nodepool2.google_container_node_pool.node_pool will be created
+ resource "google_container_node_pool" "node_pool" {
      + cluster                     = (sensitive value)
      + id                          = (known after apply)
      + initial_node_count          = 1
      + instance_group_urls         = (known after apply)
      + location                    = (sensitive value)
      + managed_instance_group_urls = (known after apply)
      + max_pods_per_node           = (known after apply)
      + name                        = (known after apply)
      + name_prefix                 = "trusted-pool2-"
      + node_count                  = (known after apply)
      + node_locations              = [
          + "us-central1-a",
          + "us-central1-b",
          + "us-central1-c",
        ]
      + operation                   = (known after apply)
      + project                     = "k8s-infra-prow-build-trusted"
      + version                     = (known after apply)

      + autoscaling {
          + location_policy = (known after apply)
          + max_node_count  = 6
          + min_node_count  = 1
        }

      + management {
          + auto_repair  = true
          + auto_upgrade = true
        }

      + network_config (known after apply)

      + node_config {
          + disk_size_gb     = 200
          + disk_type        = "hyperdisk-balanced"
          + effective_taints = (known after apply)
          + image_type       = "UBUNTU_CONTAINERD"
          + labels           = (known after apply)
          + local_ssd_count  = (known after apply)
          + logging_variant  = (known after apply)
          + machine_type     = "c4-highmem-8"
          + metadata         = {
              + "disable-legacy-endpoints" = "true"
            }
          + min_cpu_platform = (known after apply)
          + oauth_scopes     = [
              + "https://www.googleapis.com/auth/cloud-platform",
            ]
          + preemptible      = false
          + service_account  = "gke-nodes-prow-build-trusted@k8s-infra-prow-build-trusted.iam.gserviceaccount.com"
          + spot             = false

          + confidential_nodes (known after apply)

          + gcfs_config (known after apply)

          + guest_accelerator (known after apply)

          + kubelet_config (known after apply)

          + shielded_instance_config (known after apply)

          + windows_node_config (known after apply)

          + workload_metadata_config {
              + mode = "GKE_METADATA"
            }
        }

      + upgrade_settings (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.
  • ▶️ To apply this plan, comment:
    atlantis apply -d infra/gcp/terraform/k8s-infra-prow-build-trusted
  • 🚮 To delete this plan and lock, click here
  • 🔁 To plan this project again, comment:
    atlantis plan -d infra/gcp/terraform/k8s-infra-prow-build-trusted

Plan: 1 to add, 0 to change, 0 to destroy.


  • ⏩ To apply all unapplied plans from this Pull Request, comment:
    atlantis apply
  • 🚮 To delete all plans and locks from this Pull Request, comment:
    atlantis unlock

@upodroid
Copy link
Member Author

upodroid commented Jun 3, 2025

atlantis apply

@k8s-infra-ci-robot
Copy link
Contributor

Ran Apply for dir: infra/gcp/terraform/k8s-infra-prow-build-trusted workspace: default

Show Output
module.prow_build_nodepool2.google_container_node_pool.node_pool: Creating...
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [00m10s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [00m20s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [00m30s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [00m40s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [00m50s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m00s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m10s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m20s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m30s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m40s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [01m50s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m00s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m10s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m20s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m30s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m40s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [02m50s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m00s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m10s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m20s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m30s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m40s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [03m50s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Still creating... [04m00s elapsed]
module.prow_build_nodepool2.google_container_node_pool.node_pool: Creation complete after 4m2s [id=projects/k8s-infra-prow-build-trusted/locations/us-central1/clusters/prow-build-trusted/nodePools/trusted-pool2-20250603102405724200000001]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

@ameukam
Copy link
Member

ameukam commented Jun 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9d09a4a into kubernetes:main Jun 6, 2025
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 6, 2025
@k8s-infra-ci-robot
Copy link
Contributor

Locks and plans deleted for the projects and workspaces modified in this pull request:

  • dir: infra/gcp/terraform/k8s-infra-prow-build-trusted workspace: default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants