-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promoter: add 20191021-v2.3.1-34-ge32056e #406
Conversation
This version has the new "-thin-manifest-dir" flag to support separating out images metadata (registry information, credentials) from the actual images themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now all I can do is rubber-stamp. In the future, we should link to proof-of-testing as a prereq for promotion (for all repos, not just this :)
Thanks!
/lgtm
/approve
/assign @nikhita I've created an issue to address Tim's comment: kubernetes-sigs/promo-tools#144. In spirit it is closely interrelated with @Katharine's recent proposal about automatically building staging images here: https://docs.google.com/document/d/1E2GOa3b9OgrI0PS2R-UVWDRi-m_Vd3va7cOkDQHDm5w/edit#heading=h.fvtprlh40nl2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@listx looks like we should add an OWNERS file here: https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io/k8s-staging-artifact-promoter :) |
This is a pure file rename to match the naming convention [1] in the upcoming (recently promoted) promoter version [2]. No functional change. [1]: kubernetes-sigs/promo-tools@8f464c1 [2]: kubernetes#406
This is a pure file rename to match the naming convention [1] in the upcoming (recently promoted) promoter version [2]. No functional change. [1]: kubernetes-sigs/promo-tools@8f464c1 [2]: kubernetes#406
This version has the new "-thin-manifest-dir" flag to support separating
out images metadata (registry information, credentials) from the actual
images themselves.
/assign @thockin