Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promoter: add 20191021-v2.3.1-34-ge32056e #406

Merged
merged 1 commit into from
Oct 21, 2019
Merged

promoter: add 20191021-v2.3.1-34-ge32056e #406

merged 1 commit into from
Oct 21, 2019

Conversation

listx
Copy link
Contributor

@listx listx commented Oct 21, 2019

This version has the new "-thin-manifest-dir" flag to support separating
out images metadata (registry information, credentials) from the actual
images themselves.

/assign @thockin

promoter: add 20191021-v2.3.1-34-ge32056e
e1d3232 
This version has the new "-thin-manifest-dir" flag to support separating
out images metadata (registry information, credentials) from the actual
images themselves.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2019
thockin
thockin reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now all I can do is rubber-stamp. In the future, we should link to proof-of-testing as a prereq for promotion (for all repos, not just this :)

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019
@listx listx mentioned this pull request Oct 21, 2019
Closed
@listx
Copy link
Contributor Author

listx commented Oct 21, 2019

/assign @nikhita

I've created an issue to address Tim's comment: kubernetes-sigs/promo-tools#144. In spirit it is closely interrelated with @Katharine's recent proposal about automatically building staging images here: https://docs.google.com/document/d/1E2GOa3b9OgrI0PS2R-UVWDRi-m_Vd3va7cOkDQHDm5w/edit#heading=h.fvtprlh40nl2

nikhita
nikhita approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit e052401 into kubernetes:master Oct 21, 2019
@nikhita
Copy link
Member

nikhita commented Oct 21, 2019

@listx looks like we should add an OWNERS file here: https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io/k8s-staging-artifact-promoter :)

@listx
Copy link
Contributor Author

listx commented Oct 21, 2019

@nikhita Noted; #407 PTAL

listx pushed a commit to listx/k8s.io that referenced this pull request Oct 21, 2019
rename promoter manifestso
99cbf8a 
This is a pure file rename to match the naming convention [1] in the
upcoming (recently promoted) promoter version [2].

No functional change.

[1]: kubernetes-sigs/promo-tools@8f464c1
[2]: kubernetes#406
listx pushed a commit to listx/k8s.io that referenced this pull request Oct 21, 2019
rename promoter manifests
d652770 
This is a pure file rename to match the naming convention [1] in the
upcoming (recently promoted) promoter version [2].

No functional change.

[1]: kubernetes-sigs/promo-tools@8f464c1
[2]: kubernetes#406
This was referenced Oct 21, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@nikhita nikhita nikhita approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

Assignees

@thockin thockin

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@listx @k8s-ci-robot @nikhita @thockin