-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prod projects for GCR backups #376
Conversation
I'm not sure if a test-only backup gcr is necessary at this point, but I don't feel strongly either way so |
infra/gcp/ensure-prod-storage.sh
Outdated
"${PROMOTER_TESTPROD_PROJECT}" | ||
"${PROD_PROJECT}-backup" | ||
"${PROMOTER_TEST_PROD_PROJECT}" | ||
"${PROMOTER_TEST_PROD_PROJECT}-backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, instead of "${PROMOTER_TEST_PROD_PROJECT}-backup"
can you create 2 separate ones called
k8s-cip-test-prod2
and k8s-cip-test-prod2-backup
? This is because I need a place to run the e2e test that will restore images from the latter to the former, independent of the existing ${PROMOTER_TEST_PROD_PROJECT}
(the existing promoter e2e tests wipe images off of that one and I don't want the two tests to collide with each other).
(If you can think of a better name, please suggest.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
This now defines "k8s-artifacts-prod-bak" as the backup project for "k8s-artifacts-prod" and adds "k8s-gcr-backup-test-prod" and "k8s-gcr-backup-test-prod-bak" as parallels to that explicitly for testing. Satisfactory? |
Satisfactory! Thanks /lgtm |
/assign @cblecker |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: listx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
self-approved. I will actuate this now |
Actuated, now you can see if we got it all right :) |
Tentatively the https://console.cloud.google.com/gcr/images/k8s-gcr-backup-test-prod/GLOBAL link does not show me an error (same for the other 2) so I think they were set up correctly. I will need temporary write access to the test-backup ("k8s-gcr-backup-test-prod" and "k8s-gcr-backup-test-prod-bak") GCRs but I'll ping you for that (hmm unless this is done already...). |
Fixes #375