Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prod projects for GCR backups #376

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Add prod projects for GCR backups #376

merged 1 commit into from
Oct 23, 2019

Conversation

thockin
Copy link
Member

@thockin thockin commented Sep 26, 2019

Fixes #375

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2019
@listx
Copy link
Contributor

listx commented Sep 26, 2019

I'm not sure if a test-only backup gcr is necessary at this point, but I don't feel strongly either way so
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2019
@thockin thockin mentioned this pull request Sep 26, 2019
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
listx
listx reviewed Oct 22, 2019
View reviewed changes
infra/gcp/ensure-prod-storage.sh Outdated
"${PROMOTER_TESTPROD_PROJECT}"
"${PROD_PROJECT}-backup"
"${PROMOTER_TEST_PROD_PROJECT}"
"${PROMOTER_TEST_PROD_PROJECT}-backup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, instead of "${PROMOTER_TEST_PROD_PROJECT}-backup" can you create 2 separate ones called

k8s-cip-test-prod2 and k8s-cip-test-prod2-backup ? This is because I need a place to run the e2e test that will restore images from the latter to the former, independent of the existing ${PROMOTER_TEST_PROD_PROJECT} (the existing promoter e2e tests wipe images off of that one and I don't want the two tests to collide with each other).

(If you can think of a better name, please suggest.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@listx listx mentioned this pull request Oct 23, 2019
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2019
@thockin
Copy link
Member Author

thockin commented Oct 23, 2019

This now defines "k8s-artifacts-prod-bak" as the backup project for "k8s-artifacts-prod" and adds "k8s-gcr-backup-test-prod" and "k8s-gcr-backup-test-prod-bak" as parallels to that explicitly for testing.

Satisfactory?

@listx
Copy link
Contributor

listx commented Oct 23, 2019

Satisfactory! Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2019
@listx
Copy link
Contributor

listx commented Oct 23, 2019

/assign @cblecker

@thockin thockin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member Author

thockin commented Oct 23, 2019

self-approved. I will actuate this now

@k8s-ci-robot k8s-ci-robot merged commit 43f51c5 into kubernetes:master Oct 23, 2019
@thockin
Copy link
Member Author

thockin commented Oct 23, 2019

Actuated, now you can see if we got it all right :)

@listx
Copy link
Contributor

listx commented Oct 23, 2019

Tentatively the https://console.cloud.google.com/gcr/images/k8s-gcr-backup-test-prod/GLOBAL link does not show me an error (same for the other 2) so I think they were set up correctly. I will need temporary write access to the test-backup ("k8s-gcr-backup-test-prod" and "k8s-gcr-backup-test-prod-bak") GCRs but I'll ping you for that (hmm unless this is done already...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listx listx listx left review comments

@cblecker cblecker Awaiting requested review from cblecker

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@listx listx

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create backup GCR for gcr.io/k8s-artifacts-prod
4 participants
@thockin @listx @k8s-ci-robot @cblecker