-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra/gcp: manage more secrets via bash #2078
Merged
k8s-ci-robot
merged 7 commits into
kubernetes:main
from
spiffxp:manage-secrets-via-bash
May 24, 2021
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6cee075
infra/gcp/lib_gsm: fix ensure_serviceaccount_key_secret
spiffxp 0588d00
infra/gcp/lib_gsm: fix shellcheck nits
spiffxp 393c027
infra/gcp/lib_gsm: add convenience funcs
spiffxp a8fd682
infra/gcp/main: manage kubernetes-public secrets
spiffxp 05687ec
infra/gcp/prow: refactor into functions
spiffxp 36c13d1
infra/gcp/prow: manage prow-build-trusted secrets
spiffxp e8fea9f
infra/gcp/prow: add snyk-token secret
spiffxp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spiffxp kubernetes-external-secrets is up and running. Before we switch to
ExternalSecret
, for each secret created in kubernetes-public we need to add a new version containing only the value of thedata
field instead of the whole Kubernetes Secret.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #2091, I couldn't find an umbrella issue for this at a glance but may have missed it