Skip to content

Bump Terraform provider for aaa #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented May 6, 2021

Followup of #2008

Bump terraform provider and align with build clusters
Reuse the data resources we removed in #2008.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

ameukam added 3 commits May 7, 2021 00:23
Ensure the terraform version used by any operator is aligned with the
state version.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Bump version of the terraform provider and align it with minimum version
used for the build clusters.

No change expected.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Revert change introduced in
kubernetes@65792ae.
The provider is now in 3.x; we can reuse data resources.

No change expected.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin May 6, 2021 22:55
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2021
@ameukam
Copy link
Member Author

ameukam commented May 6, 2021

How to test:

gh pr checkout 2012
terraform init 
terraform plan

No change expected

/hold
/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented May 7, 2021

/hold cancel
I'll deploy

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 091598b into kubernetes:main May 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 7, 2021
@spiffxp
Copy link
Member

spiffxp commented May 7, 2021

No change, as expected. I ran terraform refresh for grins

@ameukam
Copy link
Member Author

ameukam commented May 8, 2021

Ref: #1403

@spiffxp
Copy link
Member

spiffxp commented Jun 14, 2021

Upgrading terraform ref: #2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants