Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra/gcp/prod-storage: fix ensure-prod-storage.sh #1998

Merged
merged 3 commits into from
May 4, 2021
Merged

infra/gcp/prod-storage: fix ensure-prod-storage.sh #1998

merged 3 commits into from
May 4, 2021

Commits on May 4, 2021

  1. infra/gcp/prod: pull into functions

    @spiffxp
    spiffxp committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7e58d3a View commit details
    Browse the repository at this point in the history

  2. infra/gcp/prod: fix shellcheck nits

    @spiffxp
    spiffxp committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ecc1ef0 View commit details
    Browse the repository at this point in the history

  3. infra/gcp/prod: fix auditor serviceaccount creation 

    Ensure the auditor service accounts are created _before_ attempting to
set an iam policy binding on the service accounts.

I will save redoing this to pull out the logic hidden in lib.sh for a
future PR
    @spiffxp
    spiffxp committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e9d73af View commit details
    Browse the repository at this point in the history