Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update audit for 2021-04-27 #1977

Closed
wants to merge 1 commit into from
Closed

Update audit for 2021-04-27 #1977

wants to merge 1 commit into from

Conversation

BobyMCbobs
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/audit Audit of project resources, audit followup issues, code in audit/ labels Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 26, 2021
@BobyMCbobs
Copy link
Member Author

/assign @spiffxp

spiffxp
spiffxp suggested changes May 4, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what's the purpose of this PR? I have been keeping tabs on #1903 as an audit PR with outstanding changes, I will merge that when things I commented on there have been resolved or created as followup issues

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BobyMCbobs
To complete the pull request process, please ask for approval from spiffxp after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@BobyMCbobs: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@spiffxp
Copy link
Member

spiffxp commented May 5, 2021

/close
Please /reopen and rebase if you think this remains relevant

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
Please /reopen and rebase if you think this remains relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BobyMCbobs
Copy link
Member Author

Sorry, what's the purpose of this PR? I have been keeping tabs on #1903 as an audit PR with outstanding changes, I will merge that when things I commented on there have been resolved or created as followup issues

Needed some update on the observability of the k8s-infra-ii-sandbox project permissions and what was on main seemed out of date.
My PR is not needed anymore, since #2001 has merged.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp requested changes

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobyMCbobs @k8s-ci-robot @spiffxp