Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry static linking #9286

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 10, 2022

What this PR does / why we need it:

This PR statically links OpenTelemetry dependencies to reduce the number and the size of the files stored in the side-car container.
The size of container image is reduced from ~50 to ~17 MB.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

related to #9016

How Has This Been Tested?

otel_static
otel_static_config

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

OpenTelemetry static linking

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @esigo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2022
@esigo esigo changed the title OpenTelemetry static link OpenTelemetry static linking Nov 10, 2022
@strongjz
Copy link
Member

/ok-to-test

/triage accepted
/priority backlog
/kind feature

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 10, 2022
@rikatz
Copy link
Contributor

rikatz commented Nov 13, 2022

/lgtm
/approve
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2022
@rikatz
Copy link
Contributor

rikatz commented Nov 13, 2022

/hold

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 13, 2022
@rikatz
Copy link
Contributor

rikatz commented Nov 13, 2022

Just a question before merging, will this work with our current v1.21 version? How can we keep this in sync?

Otherwise feel free to unhold :)

@strongjz
Copy link
Member

@rikatz I dropped 1.21 from the supported table and removed it from e2e since 1.21 was EOL last month.

@rikatz
Copy link
Contributor

rikatz commented Nov 13, 2022

Sorry nginx v1.21, not k8s

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2022
@esigo
Copy link
Member Author

esigo commented Nov 13, 2022

Sorry nginx v1.21, not k8s

@rikatz thanks. 1.21 should work with my last commit. I'll test tomorrow.

@esigo
Copy link
Member Author

esigo commented Nov 14, 2022

@rikatz tested with nginx 1.21:
otel_static_121

@rikatz
Copy link
Contributor

rikatz commented Nov 14, 2022

Pardon my ignorance, but this errors in the end of the log are something concerning?

@esigo
Copy link
Member Author

esigo commented Nov 14, 2022

Pardon my ignorance, but this errors in the end of the log are something concerning?

Here I was able to load the module and the errors mean the collector/backend is not reachable. So I could produce traces but I send them to an address that does not exist and hence the errors. #9062 should be merged in order to configure the collector correctly.

@rikatz
Copy link
Contributor

rikatz commented Nov 14, 2022

Thanks!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@rikatz
Copy link
Contributor

rikatz commented Nov 14, 2022

/lgtm
Thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esigo, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a66ee73 into kubernetes:main Nov 14, 2022
@esigo esigo deleted the otel-static branch November 14, 2022 20:08
@esigo esigo mentioned this pull request Nov 15, 2022
11 tasks
jaehnri pushed a commit to jaehnri/ingress-nginx that referenced this pull request Jan 2, 2023
* static otel lib

* clean

* nginx 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants