Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add this to Helm chart's values file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I had a suspicion that these files were generated but I'm not familiar with helm. It will take too much time for me to do it, but I don't mind to contribute / donate if someone is willing to pick this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it!
7ffc2a2
I would be grateful for any help moving this through testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 if you need any help please feel free to ping me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, i'm giving it a go after all.
I managed to install go, helm, kind and make on Ubuntu WSL2, but while running
make dev-env
, it cannot connect tolocalhost:8080
due to a limitation in WSL2 where the ubuntu instance cannot access the host machine under the name 'localhost'.Is there anywhere where I can replace the hostname which is used during
make dev-env
? even if its temporarily/locally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overwrote localhost with my windows IP in
/etc/hosts
, but I still get the same error:I confirmed that neither in Windows nor in Ubuntu any service is running on 8080 (
telnet 127.0.0.1 8080
on both envs).Any idea what might go wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you set any proxy before you run
make dev-env
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no proxies configured in my WSL, no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, now it seems to work...
i deleted
ingress-nginx-dev-control-plane
and re-ranmake dev-env
:-SThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, make test failed, but make e2e passed.
Not sure what to do with the normal make tests.
Maybe its good enough for further testing by you guys?
make test Failed
e2e test logs