-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handling of path Prefix and Exact #6443
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5252a8a
to
87c4ce9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6443 +/- ##
==========================================
- Coverage 55.81% 55.61% -0.21%
==========================================
Files 89 90 +1
Lines 6358 6421 +63
==========================================
+ Hits 3549 3571 +22
- Misses 2369 2409 +40
- Partials 440 441 +1
Continue to review full report at Codecov.
|
@aledbf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-ingress-nginx-e2e-1-16 |
/test pull-ingress-nginx-e2e-1-17 |
What this PR does / why we need it:
Replaces #6440
fixes #6437
fixes #6449
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: