Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test images #6392

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Update test images #6392

merged 4 commits into from
Oct 29, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 29, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@aledbf
Copy link
Member Author

aledbf commented Oct 29, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #6392 into master will decrease coverage by 0.03%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6392      +/-   ##
==========================================
- Coverage   55.81%   55.78%   -0.04%     
==========================================
  Files          89       89              
  Lines        6358     6382      +24     
==========================================
+ Hits         3549     3560      +11     
- Misses       2369     2381      +12     
- Partials      440      441       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 4.25% <0.00%> (-0.05%) ⬇️
internal/ingress/controller/controller.go 46.93% <0.00%> (ø)
internal/ingress/controller/nginx.go 28.91% <ø> (ø)
internal/k8s/main.go 48.21% <0.00%> (-0.88%) ⬇️
...ternal/ingress/annotations/sessionaffinity/main.go 57.77% <28.57%> (ø)
internal/ingress/annotations/annotations.go 80.88% <33.33%> (ø)
internal/ingress/controller/store/store.go 58.94% <36.36%> (-0.11%) ⬇️
internal/ingress/controller/util.go 55.26% <50.00%> (-2.81%) ⬇️
internal/ingress/status/status.go 68.70% <54.54%> (-1.37%) ⬇️
internal/ingress/controller/template/template.go 77.27% <83.33%> (+0.16%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7419c15...42c5940. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2020
@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@aledbf aledbf merged commit 789021e into kubernetes:master Oct 29, 2020
@aledbf aledbf deleted the test branch October 29, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants