-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix liveness and readiness probe path in daemonset chart #6326
Conversation
Hi @kolorful. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @ChiefAlexander |
Thanks for the PR. You will also need to bump the chart version located here: https://github.com/kubernetes/ingress-nginx/blob/master/charts/ingress-nginx/Chart.yaml#L3 |
Updated to 3.7.1 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, kolorful The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix liveness and readiness probe path in daemonset chart
What this PR does / why we need it:
This PR makes the path field on both readiness and liveness probe of the DaemonSet chart
{{ .Values.controller.healthCheckPath }}
. instead of a hardcoded valuehealthz
.This is already the case in Deployment chart, but not in DaemonSet.
ingress-nginx/charts/ingress-nginx/templates/controller-deployment.yaml
Line 145 in a6d6035
Types of changes
How Has This Been Tested?
I ran test locally and use
helm template
command to validate the field is correct locally.Checklist: