Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for NGINX reloads #6234

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Add events for NGINX reloads #6234

merged 2 commits into from
Sep 27, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 26, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #6234 into master will decrease coverage by 2.18%.
The diff coverage is 49.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6234      +/-   ##
==========================================
- Coverage   58.71%   56.53%   -2.19%     
==========================================
  Files          88       88              
  Lines        6966     6345     -621     
==========================================
- Hits         4090     3587     -503     
+ Misses       2427     2315     -112     
+ Partials      449      443       -6     
Impacted Files Coverage Δ
cmd/nginx/main.go 4.44% <0.00%> (-0.94%) ⬇️
internal/file/file.go 100.00% <ø> (ø)
internal/ingress/annotations/annotations.go 80.88% <ø> (-0.81%) ⬇️
internal/ingress/annotations/authreq/main.go 71.02% <ø> (-2.09%) ⬇️
...ternal/ingress/annotations/backendprotocol/main.go 100.00% <ø> (ø)
internal/ingress/annotations/parser/main.go 73.33% <ø> (-2.01%) ⬇️
internal/ingress/annotations/rewrite/main.go 48.78% <ø> (-1.22%) ⬇️
...nternal/ingress/annotations/secureupstream/main.go 100.00% <ø> (ø)
...ternal/ingress/annotations/sessionaffinity/main.go 57.77% <ø> (-2.64%) ⬇️
internal/ingress/controller/endpoints.go 92.68% <ø> (-0.66%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd891f...2ed3869. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test e2e-1-19

@k8s-ci-robot
Copy link
Contributor

@aledbf: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-ingress-nginx-boilerplate
  • /test pull-ingress-nginx-codegen
  • /test pull-ingress-nginx-gofmt
  • /test pull-ingress-nginx-golint
  • /test pull-ingress-nginx-lualint
  • /test pull-ingress-nginx-chart-lint
  • /test pull-ingress-nginx-test-lua
  • /test pull-ingress-nginx-test
  • /test pull-ingress-nginx-e2e-1-15
  • /test pull-ingress-nginx-e2e-1-16
  • /test pull-ingress-nginx-e2e-1-17
  • /test pull-ingress-nginx-e2e-1-18
  • /test pull-ingress-nginx-e2e-1-19
  • /test pull-ingress-nginx-e2e-helm-chart

Use /test all to run the following jobs:

  • pull-ingress-nginx-boilerplate
  • pull-ingress-nginx-codegen
  • pull-ingress-nginx-gofmt
  • pull-ingress-nginx-golint
  • pull-ingress-nginx-test

In response to this:

/test e2e-1-19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19
/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2020
@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19
/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19
/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19
/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/test pull-ingress-nginx-e2e-1-19
/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-17

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 27, 2020

@aledbf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-e2e-1-18 916bec0 link /test pull-ingress-nginx-e2e-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf
Copy link
Member Author

aledbf commented Sep 27, 2020

/retest

@aledbf aledbf merged commit a767b1d into kubernetes:master Sep 27, 2020
@aledbf aledbf deleted the ref branch September 27, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants