-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo "permanen" #5971
Fixed typo "permanen" #5971
Conversation
Noticed the use of the name "permanen-redirect" instead of "permanent-redirect" in some annotations for this test
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ryanwilsonperkin! |
Hi @ryanwilsonperkin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/check-cla |
@ryanwilsonperkin please sign the CLA |
Codecov Report
@@ Coverage Diff @@
## master #5971 +/- ##
==========================================
+ Coverage 58.65% 58.71% +0.06%
==========================================
Files 88 88
Lines 6951 6966 +15
==========================================
+ Hits 4077 4090 +13
- Misses 2425 2427 +2
Partials 449 449
Continue to review full report at Codecov.
|
@aledbf all done now 👍 |
/lgtm |
@ryanwilsonperkin thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ryanwilsonperkin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixed the use of the name "permanen-redirect" instead of "permanent-redirect" in some annotations for this test
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
It has not, I am new to this project and would be happy to test it if need be, but it does not seem to be something that would necessarily need it (unless changed annotations break part of the test system)
Checklist: