Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pull requests using github actions #5836

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 1, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@aledbf aledbf force-pushed the test-ga branch 14 times, most recently from cd4ebfa to 8ab4c7a Compare July 2, 2020 04:50
@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2020

/retest

@aledbf aledbf force-pushed the test-ga branch 4 times, most recently from 17335d8 to a21332d Compare July 2, 2020 17:56
@codecov-commenter
Copy link

Codecov Report

Merging #5836 into master will increase coverage by 0.03%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5836      +/-   ##
==========================================
+ Coverage   58.65%   58.68%   +0.03%     
==========================================
  Files          88       88              
  Lines        6951     6959       +8     
==========================================
+ Hits         4077     4084       +7     
  Misses       2425     2425              
- Partials      449      450       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 5.37% <0.00%> (ø)
internal/ingress/annotations/class/main.go 54.54% <ø> (ø)
internal/ingress/controller/controller.go 49.59% <ø> (ø)
internal/ingress/controller/nginx.go 30.10% <50.00%> (+0.10%) ⬆️
internal/ingress/controller/store/store.go 58.57% <50.00%> (-0.20%) ⬇️
cmd/nginx/flags.go 82.56% <100.00%> (+0.18%) ⬆️
internal/ingress/metric/collectors/process.go 90.62% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d1eb6...a21332d. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2020

/retest

@aledbf aledbf force-pushed the test-ga branch 2 times, most recently from 68a1f99 to 4047542 Compare July 2, 2020 20:22
@aledbf aledbf force-pushed the test-ga branch 3 times, most recently from 8877267 to 33d79d6 Compare July 2, 2020 21:49
@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2020

/retest

@aledbf aledbf merged commit 5f81b84 into kubernetes:master Jul 3, 2020
@aledbf aledbf deleted the test-ga branch July 3, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants