-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quoting to sysctls because numeric values need to be strings #5823
Conversation
Hi @towolf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@towolf thanks! |
/retest |
2 similar comments
/retest |
/retest |
@towolf just in case, the errors are not related to the PR itself but slow prow jobs |
Yeah, keep 'em coming! |
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, cmluciano, towolf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
@towolf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Sorry, I missed this problem with my previous PR #5752:
Error: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.SecurityContext: v1.PodSecurityContext.Sysctls: []v1.Sysctl: v1. Sysctl.Value: ReadString: expects " or n, but found 8, error found in #10 byte of ...|,"value":8192}]},"se|..., bigger context ...|{"sysctls":[{"name":"net.core.somaxconn","value":8192}]},"serviceAccountName":"...
Types of changes
How Has This Been Tested?
Tested with numeric values for sysctls:
Checklist: