Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor directory and enable go modules #5764

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 24, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@aledbf aledbf changed the title Vendor Remove vendor directory and enable go modules Jun 24, 2020
@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/test all

@codecov-commenter
Copy link

Codecov Report

Merging #5764 into master will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5764   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          88       88           
  Lines        6951     6959    +8     
=======================================
+ Hits         4077     4082    +5     
- Misses       2425     2426    +1     
- Partials      449      451    +2     
Impacted Files Coverage Δ
cmd/nginx/main.go 5.37% <0.00%> (ø)
internal/ingress/annotations/class/main.go 54.54% <ø> (ø)
internal/ingress/controller/controller.go 49.59% <ø> (ø)
internal/ingress/controller/nginx.go 30.10% <50.00%> (+0.10%) ⬆️
internal/ingress/controller/store/store.go 58.57% <50.00%> (-0.20%) ⬇️
cmd/nginx/flags.go 82.56% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b88e3...51321fc. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

2 similar comments
@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@aledbf aledbf merged commit 9cfdb76 into kubernetes:master Jun 24, 2020
@aledbf aledbf deleted the vendor branch June 24, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants