-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to define trusted addresses for proxy protocol in stream block #5757
Conversation
Hi @agile6v. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR could be merged after the latest Nginx image is released. #5747 |
/ok-to-test |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Would be great to have a corresponding test in https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/settings/proxy_protocol.go but this might already be covered.
/retest |
@agile6v please add e2e tests |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
@cmluciano @aledbf Added e2e tests. Sorry for the delay. |
ping @cmluciano @aledbf |
/lgtm |
@agile6v thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agile6v, aledbf, cmluciano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
support to define trusted addresses for proxy protocol in stream block.
Types of changes
Which issue/s this PR fixes
fixes #4430
Checklist: