Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic LB sync non-external backends only when necessary #5726

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 16, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5418
fixes #4808

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@aledbf
Copy link
Member Author

aledbf commented Jun 16, 2020

/retest

3 similar comments
@aledbf
Copy link
Member Author

aledbf commented Jun 16, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 17, 2020

/assign @ElvinEfendi

@aledbf
Copy link
Member Author

aledbf commented Jun 17, 2020

@ZxYuan are you ok if we tried to merge this PR?. Is #5418 with the required fixes to pass e2e tests.
Or you want to finish #5418?

@ZxYuan
Copy link
Contributor

ZxYuan commented Jun 17, 2020

@ZxYuan are you ok if we tried to merge this PR?. Is #5418 with the required fixes to pass e2e tests.
Or you want to finish #5418?

lgtm

@ElvinEfendi
Copy link
Member

@aledbf are you planning to write some tests?

@aledbf
Copy link
Member Author

aledbf commented Jun 23, 2020

@aledbf are you planning to write some tests?

Can you help me with that?

@ZxYuan
Copy link
Contributor

ZxYuan commented Jun 26, 2020

@aledbf are you planning to write some tests?

Can you help me with that?

So sorry that I've been tied up recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about calling sync_backends every second
4 participants