Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e externalName test #5725

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix e2e externalName test #5725

merged 1 commit into from
Jun 16, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 16, 2020

What this PR does / why we need it:

httpbin.org is validating the host field now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #5725 into master will increase coverage by 0.01%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5725      +/-   ##
==========================================
+ Coverage   58.65%   58.66%   +0.01%     
==========================================
  Files          88       88              
  Lines        6951     6956       +5     
==========================================
+ Hits         4077     4081       +4     
  Misses       2425     2425              
- Partials      449      450       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 5.37% <0.00%> (ø)
internal/ingress/controller/store/store.go 58.57% <50.00%> (-0.20%) ⬇️
internal/ingress/metric/collectors/process.go 90.62% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5a4bc...2590c6a. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jun 16, 2020

/test pull-ingress-nginx-e2e-1-18
/test pull-ingress-nginx-e2e-1-16
/test pull-ingress-nginx-e2e-1-15

@aledbf aledbf merged commit c0035d2 into kubernetes:master Jun 16, 2020
@aledbf aledbf deleted the e2 branch June 16, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants