Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysctl exemptions to controller PSP #5708

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

towolf
Copy link
Contributor

@towolf towolf commented Jun 12, 2020

What this PR does / why we need it:

I would like to be able to support this construction in my DaemonSet, I have control over the host and this is the easiest way to bump the socket properties.

securityContext:
  sysctls:
    - name: net.core.somaxconn
      value: "8192"

Since the PSP needs to whitelist this specific sysctl I'd like to be able to prvoide a map of sysctls, and not merge this into the securityContext.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @towolf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @towolf!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2020
@ChiefAlexander
Copy link
Contributor

/ok-to-test
/assign @ChiefAlexander

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2020
@ChiefAlexander
Copy link
Contributor

You will need to bump the chart version before we are able to get this in.

@towolf
Copy link
Contributor Author

towolf commented Jun 15, 2020

@ChiefAlexander bumped version only in Chart.yml, is that sufficient?

Do I also have to replace the version in the Makefile, in the docs, Changelog, etc? re-generate the files under ./deploy/static/?

@ChiefAlexander
Copy link
Contributor

bumped version only in Chart.yml, is that sufficient?

Yup, that is all you need todo. The generation of the files under static is done on release.

@ChiefAlexander
Copy link
Contributor

/lgtm

@ChiefAlexander
Copy link
Contributor

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@ChiefAlexander
Copy link
Contributor

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@ChiefAlexander
Copy link
Contributor

ChiefAlexander commented Jun 16, 2020

Sorry, one extra thing @towolf
Please Squash your commits down. https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#6-squashing

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2020
@towolf
Copy link
Contributor Author

towolf commented Jun 16, 2020

@ChiefAlexander sure, done.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 16, 2020
@towolf
Copy link
Contributor Author

towolf commented Jun 16, 2020

/assign @ChiefAlexander

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2020

@towolf: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-test-lua 836d370d93d570f6b47847f5e0d4a34534dc1814 link /test pull-ingress-nginx-test-lua
pull-ingress-nginx-lualint 836d370d93d570f6b47847f5e0d4a34534dc1814 link /test pull-ingress-nginx-lualint
pull-ingress-nginx-test 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-test
pull-ingress-nginx-e2e-1-15 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-e2e-1-15
pull-ingress-nginx-e2e-1-17 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-e2e-1-17
pull-ingress-nginx-golint 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-golint
pull-ingress-nginx-e2e-1-16 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-e2e-1-16
pull-ingress-nginx-e2e-1-18 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-e2e-1-18
pull-ingress-nginx-gofmt 219ed09a557a71dc0ba21f3d181d5582363ed340 link /test pull-ingress-nginx-gofmt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I would like to be able to support this construction in my DaemonSet, I have coontrol over the host and this is the easiest way yo bump the socket properties.
```yaml
securityContext:
  sysctls:
    - name: net.core.somaxconn
      value: "8192"
```
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2020
@ChiefAlexander
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, towolf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit e65b2ca into kubernetes:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants