-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysctl exemptions to controller PSP #5708
Conversation
Hi @towolf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @towolf! |
/ok-to-test |
You will need to bump the chart version before we are able to get this in. |
@ChiefAlexander bumped version only in Do I also have to |
Yup, that is all you need todo. The generation of the files under static is done on release. |
/lgtm |
Thanks for the PR! |
/lgtm cancel |
Sorry, one extra thing @towolf |
@ChiefAlexander sure, done. |
/assign @ChiefAlexander |
@towolf: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I would like to be able to support this construction in my DaemonSet, I have coontrol over the host and this is the easiest way yo bump the socket properties. ```yaml securityContext: sysctls: - name: net.core.somaxconn value: "8192" ```
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, towolf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I would like to be able to support this construction in my DaemonSet, I have control over the host and this is the easiest way to bump the socket properties.
Since the PSP needs to whitelist this specific sysctl I'd like to be able to prvoide a map of sysctls, and not merge this into the securityContext.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: