Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build tags to make it compile on non linux platforms #5703

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Jun 11, 2020

What this PR does / why we need it:

Useful when developing on a non linux platform and you want to make sure locally that your changes build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sylr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2020
@aledbf
Copy link
Member

aledbf commented Jun 12, 2020

Useful when developing on a non linux platform and you want to make sure locally that your changes build.

Not sure this change makes sense. If we merge this change someone could think the ingress controller runs in a different platform than linux.

Why you don't just use make build?

@sylr
Copy link
Contributor Author

sylr commented Jun 12, 2020

@aledbf It also fixes a warning thrown by VSCODE because libcontainercgroups.FindCgroupMountpoint() is not found on MacOS.

@aledbf
Copy link
Member

aledbf commented Jun 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2020
@aledbf
Copy link
Member

aledbf commented Jun 13, 2020

/retest

@codecov-commenter
Copy link

Codecov Report

Merging #5703 into master will increase coverage by 0.17%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   58.48%   58.65%   +0.17%     
==========================================
  Files          88       88              
  Lines        6975     6951      -24     
==========================================
- Hits         4079     4077       -2     
+ Misses       2446     2425      -21     
+ Partials      450      449       -1     
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 30.00% <0.00%> (+0.27%) ⬆️
internal/ingress/controller/process/nginx.go 100.00% <ø> (+67.64%) ⬆️
internal/ingress/controller/template/template.go 79.73% <61.11%> (+0.05%) ⬆️
cmd/nginx/main.go 5.37% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589187c...c0ae83f. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 13, 2020

/retest

@aledbf
Copy link
Member

aledbf commented Jun 13, 2020

/test pull-ingress-nginx-e2e-1-15

@aledbf
Copy link
Member

aledbf commented Jun 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f0a77c into kubernetes:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants