-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use build tags to make it compile on non linux platforms #5703
Conversation
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Hi @sylr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not sure this change makes sense. If we merge this change someone could think the ingress controller runs in a different platform than linux. Why you don't just use |
@aledbf It also fixes a warning thrown by VSCODE because |
/ok-to-test |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #5703 +/- ##
==========================================
+ Coverage 58.48% 58.65% +0.17%
==========================================
Files 88 88
Lines 6975 6951 -24
==========================================
- Hits 4079 4077 -2
+ Misses 2446 2425 -21
+ Partials 450 449 -1
Continue to review full report at Codecov.
|
/retest |
/test pull-ingress-nginx-e2e-1-15 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, sylr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Useful when developing on a non linux platform and you want to make sure locally that your changes build.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: