-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out objects that belong to Helm #5702
Conversation
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Hi @sylr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @aledbf |
Can someone launch the tests ? |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5702 +/- ##
==========================================
- Coverage 58.48% 58.05% -0.43%
==========================================
Files 88 88
Lines 6975 7037 +62
==========================================
+ Hits 4079 4085 +6
- Misses 2446 2501 +55
- Partials 450 451 +1
Continue to review full report at Codecov.
|
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
@sylr thanks! |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/lgtm |
@sylr thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, sylr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Modest attempt to reduce memory consumption by avoid listing HELM related objects
Types of changes
Which issue/s this PR fixes
fixes #5697
How Has This Been Tested?
Checklist: