-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Serve correct TLS certificate for requests with uppercase host #5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve correct TLS certificate for requests with uppercase host #5669
Conversation
Hi @AndiDog. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @ElvinEfendi |
/retest |
1 similar comment
/retest |
/lgtm |
@AndiDog thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, AndiDog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AndiDog: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Merging. I will fix the lualint issue in a new PR |
What this PR does / why we need it:
Follow-up to #5456 which didn't fully solve the problem. This time, I was able to test the full flow by editing a Lua script and trying an uppercase-host request like
curl -kv https://MY-UPPERCASE-HOST/
.Types of changes
How Has This Been Tested?
Edited 0.32.0 controller image with this one-line change and saw that a request with uppercase host provides the TLS certificate specified in the
Ingress
object instead of falling back to the fake default certificate.Unfortunately I don't have a good idea how to test it, since there's no example test requesting
/configuration/servers
or similar.Checklist: