Skip to content

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Jun 5, 2020

What this PR does / why we need it:

Follow-up to #5456 which didn't fully solve the problem. This time, I was able to test the full flow by editing a Lua script and trying an uppercase-host request like curl -kv https://MY-UPPERCASE-HOST/.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Edited 0.32.0 controller image with this one-line change and saw that a request with uppercase host provides the TLS certificate specified in the Ingress object instead of falling back to the fake default certificate.

Unfortunately I don't have a good idea how to test it, since there's no example test requesting /configuration/servers or similar.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @AndiDog. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from aledbf and cmluciano June 5, 2020 15:27
@aledbf
Copy link
Member

aledbf commented Jun 5, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2020
@aledbf
Copy link
Member

aledbf commented Jun 5, 2020

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Jun 5, 2020

/retest

1 similar comment
@aledbf
Copy link
Member

aledbf commented Jun 5, 2020

/retest

@aledbf
Copy link
Member

aledbf commented Jun 9, 2020

/lgtm
/approve

@aledbf
Copy link
Member

aledbf commented Jun 9, 2020

@AndiDog thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

@AndiDog: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-lualint ab024c6 link /test pull-ingress-nginx-lualint
pull-ingress-nginx-e2e-1-16 ab024c6 link /test pull-ingress-nginx-e2e-1-16

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf
Copy link
Member

aledbf commented Jun 9, 2020

Merging. I will fix the lualint issue in a new PR

@aledbf aledbf merged commit f27b404 into kubernetes:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants