fix undefined variable $auth_cookie error due to when location is denied

[jeffistyping]

Added isLocationAllowed check before using the $auth_cookie variable in nginx.tmpl.

What this PR does / why we need it:

As described in #5130, a new reference to $auth_cookie variable does not get declared when location is denied. As a result, an Undefined Nginx variable "$auth_cookie" occurs preventing the config to be loaded properly.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5130

How Has This Been Tested?

Added an e2e test that starts a controller, installs an ingress with incorrect annotation, and then deploys another ingress and asserts that the new ingress is reflected in the Nginx configuration.

No new unit tests are needed.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @jeffrey-hui. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aledbf]

/ok-to-test

[aledbf]

/assign @ElvinEfendi

[codecov-commenter]

Codecov Report

Merging #5664 into master will increase coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
+ Coverage   58.48%   58.72%   +0.24%     
==========================================
  Files          88       88              
  Lines        6975     6946      -29     
==========================================
  Hits         4079     4079              
+ Misses       2446     2417      -29     
  Partials      450      450              

Impacted Files	Coverage Δ
internal/ingress/controller/nginx.go	30.00% <0.00%> (+0.27%)	⬆️
internal/ingress/controller/process/nginx.go	100.00% <ø> (+67.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99aad29...7767230. Read the comment docs.

[aledbf]

/retest

[ElvinEfendi]

/test pull-ingress-nginx-e2e-1-16

[jeffistyping]

/retest

[jeffistyping]

/test pull-ingress-nginx-e2e-1-16

[aledbf]

/retest

[aledbf]

/retest

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, jeffrey-hui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment