Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build of docker images #5637

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Refactor build of docker images #5637

merged 1 commit into from
Jun 2, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 2, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

This PR removes the use of docker buildx from most of the makefile tasks. This is unfortunate but trying to run e2e tests in an s390x VM I found out the latest docker version is 18.06.
There only two places where we really need to use buildx, the main makefile when we release a version and building nginx itself. In the nginx image, we also had to remove luarocks due to core dumps generated running uarocks install`.

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@aledbf aledbf force-pushed the rd branch 3 times, most recently from 3e80197 to 9dde581 Compare June 2, 2020 01:57
@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/test pull-ingress-nginx-e2e-1-15

@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/test pull-ingress-nginx-e2e-1-18

@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/retest

3 similar comments
@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@aledbf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-e2e-1-15 67c962b link /test pull-ingress-nginx-e2e-1-15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf
Copy link
Member Author

aledbf commented Jun 2, 2020

/retest

@aledbf aledbf merged commit ea8e711 into kubernetes:master Jun 2, 2020
@aledbf aledbf deleted the rd branch June 2, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants