-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build of docker images #5637
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3e80197
to
9dde581
Compare
/test pull-ingress-nginx-e2e-1-15 |
/test pull-ingress-nginx-e2e-1-18 |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@aledbf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
This PR removes the use of
docker buildx
from most of the makefile tasks. This is unfortunate but trying to run e2e tests in ans390x
VM I found out the latest docker version is 18.06.There only two places where we really need to use buildx, the main makefile when we release a version and building nginx itself. In the nginx image, we also had to remove luarocks due to core dumps generated running uarocks install`.
How Has This Been Tested?
Checklist: