-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ingress.class annotation to new IngressClassName field #5307
Conversation
c0f41da
to
7f14039
Compare
/retest |
Codecov Report
@@ Coverage Diff @@
## master #5307 +/- ##
==========================================
+ Coverage 58.64% 58.70% +0.05%
==========================================
Files 88 88
Lines 6901 6908 +7
==========================================
+ Hits 4047 4055 +8
Misses 2410 2410
+ Partials 444 443 -1
Continue to review full report at Codecov.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, cmluciano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if !k8s.IsNetworkingIngressAvailable { | ||
klog.Warningf("Using deprecated \"k8s.io/api/extensions/v1beta1\" package because Kubernetes version is < v1.14.0") | ||
} | ||
|
||
if !k8s.IsIngressV1Ready { | ||
klog.Infof("Enabling new Ingress features availables since v1.18.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log message is confusing, so we enable new ingress features in ingress V1 is NOT ready?
Hello @aledbf @cmluciano Maybe I misunderstand the code, but is it so that from now on the annotation is not taken into consideration? |
OK, I can see now. the toIngress() function puts the annotation's value into the Spec if there is annotation. So, the annotation becomes "Spec.IngressClassName" before the isValid() is called. |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: