-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ability to disable ModSecurity at location level #5276
Conversation
Welcome @bhavin192! |
Hi @bhavin192. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@bhavin192 please add e2e tests to avoid regressions. |
- Adds 'modsecurity off;' to the nginx config if the 'enable-modsecurity' annotation is set to false. - Update tests and e2e tests accordingly Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
1cf22e4
to
380ef3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #5276 +/- ##
==========================================
+ Coverage 58.58% 58.61% +0.03%
==========================================
Files 88 88
Lines 6879 6901 +22
==========================================
+ Hits 4030 4045 +15
- Misses 2407 2412 +5
- Partials 442 444 +2
Continue to review full report at Codecov.
|
/retest |
/approve |
@bhavin192 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, bhavin192 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
modsecurity off;
to the nginx config if theenable-modsecurity
annotation is set to false.Types of changes
Which issue/s this PR fixes
fixes #5005
How Has This Been Tested?
enable-modsecurity: false
annotationnginx.conf
is getting update correctly, (if it has themodsecurity off;
config in location)Checklist: