-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maxmind Editions support #5262
Conversation
Hi @foxdalas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5262 +/- ##
==========================================
+ Coverage 58.58% 58.62% +0.03%
==========================================
Files 88 88
Lines 6879 6883 +4
==========================================
+ Hits 4030 4035 +5
Misses 2407 2407
+ Partials 442 441 -1
Continue to review full report at Codecov.
|
/retest |
@foxdalas thank you for the feature, please add a validation to the names that can be used in the flag. |
@aledbf fixed. Thanks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, foxdalas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@foxdalas thanks! |
/retest |
/test pull-ingress-nginx-e2e-1-17 |
/test pull-ingress-nginx-e2e-1-15 |
/retest |
/retest |
What this PR does / why we need it:
Add support GeoIP2 Databases. (ISP for example)
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
You can add flag
--maxmind-edition-ids=GeoLite2-City,GeoLite2-ASN,GeoIP2-ISP
and checkgeoip2_isp
variable.Checklist: