Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the handling of ConfigMap creation #5052

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

janosi
Copy link
Contributor

@janosi janosi commented Feb 11, 2020

What this PR does / why we need it:

Requested in #4969 at #4969 (comment)
When a new CM is created Ingress definitions are checked for reference to the new CM an Ingress sync is triggered if such reference is found.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When a new CM is created Ingress definitions are checked for reference to the new CM an Ingress sync is triggered if such reference is found.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @janosi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2020
@aledbf
Copy link
Member

aledbf commented Feb 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2c5819e). Click here to learn what that means.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5052   +/-   ##
=========================================
  Coverage          ?   58.49%           
=========================================
  Files             ?       88           
  Lines             ?     6865           
  Branches          ?        0           
=========================================
  Hits              ?     4016           
  Misses            ?     2409           
  Partials          ?      440
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 57.02% <41.17%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5819e...42ec2cc. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Feb 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@aledbf
Copy link
Member

aledbf commented Feb 11, 2020

@janosi thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, janosi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc41dc7 into kubernetes:master Feb 11, 2020
@ElvinEfendi
Copy link
Member

ElvinEfendi commented Feb 19, 2020

Before this PR there was no reference to AnnotationsReferencesConfigmap, does this mean the PR is actually fixing a regression of not watching the configmaps listed in

var configmapAnnotations = sets.NewString(
?

@janosi any chance you can add e2e test for this regression?

@janosi
Copy link
Contributor Author

janosi commented Feb 21, 2020

@ElvinEfendi Yes, that is my understanding. Let's see if I can work on that e2e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants