-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dev-env script #4932
Cleanup dev-env script #4932
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks harmless but I'm unable to test this on MacOS at the moment. On a fresh clone with minikube installed, I get problems with building the image.
make dev-env
NAMESPACE is set to ingress-nginx
Switched to context "minikube".
[dev-env] building container
Error: No such image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller-amd64:dev
Building docker image...
unknown flag: --no-cache
Does this work for you if you don't have the image pulled?
This worked for me with
Prior to running |
Codecov Report
@@ Coverage Diff @@
## master #4932 +/- ##
=========================================
Coverage ? 58.46%
=========================================
Files ? 88
Lines ? 6729
Branches ? 0
=========================================
Hits ? 3934
Misses ? 2364
Partials ? 431 Continue to review full report at Codecov.
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: