Cleanup dev-env script

[aledbf]

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

/retest

[cmluciano]

this looks harmless but I'm unable to test this on MacOS at the moment. On a fresh clone with minikube installed, I get problems with building the image.

make dev-env             
NAMESPACE is set to ingress-nginx
Switched to context "minikube".
[dev-env] building container
Error: No such image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller-amd64:dev
Building docker image...
unknown flag: --no-cache

Does this work for you if you don't have the image pulled?

[ElvinEfendi]

This worked for me with

> ingress-nginx (cleanup-dev)$ minikube version
minikube version: v1.5.2
commit: 792dbf92a1de583fcee76f8791cff12e0c9440ad

Prior to running make dev-env I stopped and deleted minikube and ~/.minikube.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@a8a827a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4932   +/-   ##
=========================================
  Coverage          ?   58.46%           
=========================================
  Files             ?       88           
  Lines             ?     6729           
  Branches          ?        0           
=========================================
  Hits              ?     3934           
  Misses            ?     2364           
  Partials          ?      431

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a827a...af7675a. Read the comment docs.

[aledbf]

/retest

[aledbf]

/retest

[aledbf]

/retest

[aledbf]

/retest